Details

      Description

      When navigating to the faceted search page this error is thrown

      2014-06-05 10:05:25,787  WARN  [extensions.surf.DependencyAggregator] [http-bio-8080-exec-20] The file: "components/preview/pdfjs/pdf.worker.js" could not be compressed due to the following error:
       com.yahoo.platform.yui.javascript.EvaluatorException: Compilation produced 11 syntax errors.
      

      The error is removed if a bean as in ALF-15473 is added to slingshot-application-context.xml

         <bean id="dependency.aggregator" parent="dependency.aggregator.abstract" class="org.springframework.extensions.surf.DependencyAggregator">
            <property name="compressionExclusions">
               <list>
                  <value>components/preview/pdfjs/*.js</value>
               </list>
            </property>
         </bean>
      

      PdfJS viewer still works even if this error is thrown. Maybe the fix should be in Dojo dependency injection and loading the already minified version. The file pfd.worker.js does not seem to be used in the faceted search page.

        Attachments

          Issue Links

            Activity

            Hide
            ddraper David Draper added a comment -

            Peter Löfgren It's a shame that you can't see all the private branches as a couple of things have been going on this week.... firstly (as you've said) the YUI Compressor 2.4.7 won't compile PDF.js so on one branch I've done exactly what you've suggested to add the exclusions... however, on another branch we've made updates to use YUI Compressor 2.4.8 (which will compile PDF.js)...however, this isn't as easy as it sounds since YUI Compressor bundles and overrides Rhino (which we already patch as well to prevent some silly system.out calls). So this should actually be fixed, but you won't actually see the fix for some time due to our branching/development processes.

            Show
            ddraper David Draper added a comment - Peter Löfgren It's a shame that you can't see all the private branches as a couple of things have been going on this week.... firstly (as you've said) the YUI Compressor 2.4.7 won't compile PDF.js so on one branch I've done exactly what you've suggested to add the exclusions... however, on another branch we've made updates to use YUI Compressor 2.4.8 (which will compile PDF.js)...however, this isn't as easy as it sounds since YUI Compressor bundles and overrides Rhino (which we already patch as well to prevent some silly system.out calls). So this should actually be fixed, but you won't actually see the fix for some time due to our branching/development processes.
            Hide
            kroast Kevin Roast added a comment -

            This is fixed now as we have updated to 2.4.8 - it should be merged to HEAD shortly. Thanks for your patience!

            Show
            kroast Kevin Roast added a comment - This is fixed now as we have updated to 2.4.8 - it should be merged to HEAD shortly. Thanks for your patience!
            Hide
            loftux Peter Löfgren added a comment -

            With cool features coming up, there is no room for patience
            I just wished that some more of the development could be on public branches, but lets blame that on limits in Subversion and not Alfresco policys.

            Show
            loftux Peter Löfgren added a comment - With cool features coming up, there is no room for patience I just wished that some more of the development could be on public branches, but lets blame that on limits in Subversion and not Alfresco policys.
            Hide
            kroast Kevin Roast added a comment -

            All fixed now on HEAD - roll on Alfresco 5.0!

            Show
            kroast Kevin Roast added a comment - All fixed now on HEAD - roll on Alfresco 5.0!
            Hide
            alfrescoqa Alfresco QA Team added a comment -

            Verified against Community 5.0.0 (r75705-b29) schema 8,001.

            Show
            alfrescoqa Alfresco QA Team added a comment - Verified against Community 5.0.0 ( r75705 -b29) schema 8,001.

              People

              • Assignee:
                closedissues Closed Issues
                Reporter:
                kroast Kevin Roast
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: