Uploaded image for project: 'Alfresco'
  1. Alfresco
  2. ALF-21061

StartWorkflowActionExecuter bad parameter parsing

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 4.2.f Community
    • Fix Version/s: None
    • Component/s: Rules and Actions
    • Security Level: external (External user)
    • Labels:
      None
    • Security Severity:
      None

      Description

      Well, in fact this was already discussed in MNT-1415 , there was stated that it won't be fixed but no reasoning is present there.

      endStartTask parameter is parsed like this:

      // determine whether to auto-end the start task
      Boolean endStartTask = (Boolean)ruleAction.getParameterValue(PARAM_END_START_TASK);
      String startTaskTransition = (String)ruleAction.getParameterValue(PARAM_START_TASK_TRANSITION);
      endStartTask = (endStartTask == null) ? true : false;

      It "seems" quite obvious that the last sentence should be:

      endStartTask = (endStartTask == null) ? true : endStartTask;

      I can imagine that this wasn't fixed due to backward compatibility issues but this change would make the default value still be the same and at the same time honour the right parameter value not only when it is false but also when it is true.

      It doesn't seem very reasonable to expect that people who used the action and set the parameter value explicitly to "true" would expect it to behave like false, so in this case they most probably did not use the parameter at all, which won't break.

        Attachments

          Activity

          Hide
          resplin Richard Esplin added a comment -

          This issue was reported against an old version of Alfresco Community Edition.

          Alfresco Community Edition 201605 GA contains Alfresco Platform 5.1.g and Alfresco Share 5.1.f. This release includes many improvements that address old problems. We are closing old issues so that we can better prioritize our efforts.

          If you verify that the issue still exists in the latest release of Alfresco Community Edition, please reopen the issue. If you have any trouble reopening the issue, then leave a comment or email us at community@alfresco.com so that we can assist.

          Thank you for collaborating with us on improving Alfresco.

          Show
          resplin Richard Esplin added a comment - This issue was reported against an old version of Alfresco Community Edition. Alfresco Community Edition 201605 GA contains Alfresco Platform 5.1.g and Alfresco Share 5.1.f. This release includes many improvements that address old problems. We are closing old issues so that we can better prioritize our efforts. If you verify that the issue still exists in the latest release of Alfresco Community Edition, please reopen the issue. If you have any trouble reopening the issue, then leave a comment or email us at community@alfresco.com so that we can assist. Thank you for collaborating with us on improving Alfresco.

            People

            • Assignee:
              closedissues Closed Issues
              Reporter:
              iblanco Igor Blanco
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: