Uploaded image for project: 'Alfresco'
  1. Alfresco
  2. ALF-22073

MailActionExecutor doesn't consider email bodies with a HTML doctype as HTML

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Community Edition 201810 EA
    • Fix Version/s: ACS 201910-EA
    • Component/s: Repository
    • Security Level: external (External user)
    • Labels:
    • Triage:
      MNT
    • Resolution Time Custom Field:
      3 weeks, 1 hour, 39 minutes, 25 seconds

      Description

      In order to get the correct rendering in Outlook, we need to update some of our HTML email templates to include a doctype at the start. However, this causes Alfresco to send them as Plain Text instead of HTML, because the logic in MailActionExecutor to decide if a FTL template rendered into HTML or Plain Text only considers the opening HTML tag, not a HTML Doctype declaration

      The logic in the isHTML method needs to consider this too.

      (Git blame won't go far enough back to check, but I have a nasty feeling I may be the original author of this method...)

      Patch with unit test attached

        Attachments

          Issue Links

            Structure

              Activity

                People

                • Assignee:
                  closedissues Closed Issues
                  Reporter:
                  nburch Nick Burch
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Date of First Response:

                    Structure Helper Panel