Uploaded image for project: 'Repository'
  1. Repository
  2. REPO-1818

alfresco-platform-distribution POM for 5.2.d / 201612 GA includes incorrect version for Share artifacts

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: CS 5.2.1, CS 5.2.f
    • Component/s: None
    • Labels:
      None
    • Bug Priority:
      Category 1
    • Work Funnel:
      Maintenance
    • Sprint:
      Platform Delivery Sprint 14
    • Story Points:
      5

      Description

      The alfresco-platform-distribution published to artifacts.alfresco.com for the 201612 GA release (5.2.d) references an incorrect version of the Share artifacts (e.g. org.alfresco:share and org.alfresco:web-framework-commons). This is a result of the decoupling between Repository and Share, since 201612 GA consists of 5.2.d Platform and 5.2.c Share, while the referenced version for Share artifacts is 5.2.d which does not exist

      This problem can be observed with a project that includes the alfresco-platform-distribution POM for standard dependencies and includes the org.alfresco:share:classes:jar dependency. It will fail to resolve that artifact.

        Attachments

          Issue Links

            Activity

            Hide
            resplin Richard Esplin added a comment -

            Thank you Axel for reporting this issue. Unfortunately, it slipped through the cracks and we didn't get it fixed for the 201701 GA release. We will correct it for February.

            Show
            resplin Richard Esplin added a comment - Thank you Axel for reporting this issue. Unfortunately, it slipped through the cracks and we didn't get it fixed for the 201701 GA release. We will correct it for February.
            Hide
            slanglois Samuel Langlois added a comment -

            Yes, the file projects/sdk/alfresco-platform-distribution/pom.xml should not contain any reference to artifacts from Share, since it's part of Platform.
            We should remove references to the following artifacts in it:

            • <artifactId>alfresco</artifactId>
            • <artifactId>alfresco-web-client</artifactId>
            • <artifactId>alfresco-web-framework-commons</artifactId>
            • <artifactId>share</artifactId>
            • <artifactId>alfresco-wcmqs-client-api</artifactId>
            • <artifactId>alfresco-wcmqs</artifactId>
            • <artifactId>alfresco-webeditor</artifactId>
            • <artifactId>spring-surf</artifactId>
            • <artifactId>spring-surf-api</artifactId>

            To be honest, I don't think this file is really useful any more.
            It is just a duplication of information, and will always be outdated, with artifacts missing or which shouldn't be there.

            The right way, I think, is to define a property for the version of Platform, a property for the version of Share, and to add a few dependencies to the thing you need. You rely on transitive dependencies to get the whole shebang.
            You can also inherit from their respective parent poms to get the versions of everything else, like this:

                <dependencyManagement>
                    <dependencies>
                         <!-- Import all dependencyManagement from Alfresco Platform -->
                        <dependency>
                            <groupId>org.alfresco</groupId>
                            <artifactId>alfresco-parent</artifactId>
                            <version>${alfresco.platform.version}</version>
                            <type>pom</type>
                            <scope>import</scope>
                        </dependency>
                        <!-- Import all dependencyManagement from Alfresco Share-->
                        <dependency>
                            <groupId>org.alfresco</groupId>
                            <artifactId>alfresco-share-parent</artifactId>
                            <version>${alfresco.share.version}</version>
                            <type>pom</type>
                            <scope>import</scope>
                        </dependency>
                    </dependencies>
                </dependencyManagement>
            
            Show
            slanglois Samuel Langlois added a comment - Yes, the file projects/sdk/alfresco-platform-distribution/pom.xml should not contain any reference to artifacts from Share, since it's part of Platform. We should remove references to the following artifacts in it: <artifactId>alfresco</artifactId> <artifactId>alfresco-web-client</artifactId> <artifactId>alfresco-web-framework-commons</artifactId> <artifactId>share</artifactId> <artifactId>alfresco-wcmqs-client-api</artifactId> <artifactId>alfresco-wcmqs</artifactId> <artifactId>alfresco-webeditor</artifactId> <artifactId>spring-surf</artifactId> <artifactId>spring-surf-api</artifactId> To be honest, I don't think this file is really useful any more. It is just a duplication of information, and will always be outdated, with artifacts missing or which shouldn't be there. The right way, I think, is to define a property for the version of Platform, a property for the version of Share, and to add a few dependencies to the thing you need. You rely on transitive dependencies to get the whole shebang. You can also inherit from their respective parent poms to get the versions of everything else, like this: <dependencyManagement> <dependencies> <!-- Import all dependencyManagement from Alfresco Platform --> <dependency> <groupId>org.alfresco</groupId> <artifactId>alfresco-parent</artifactId> <version>${alfresco.platform.version}</version> <type>pom</type> <scope> import </scope> </dependency> <!-- Import all dependencyManagement from Alfresco Share--> <dependency> <groupId>org.alfresco</groupId> <artifactId>alfresco-share-parent</artifactId> <version>${alfresco.share.version}</version> <type>pom</type> <scope> import </scope> </dependency> </dependencies> </dependencyManagement>

              People

              • Assignee:
                Unassigned
                Reporter:
                afaust Axel Faust
              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: