[ACE-5639] Comment Activitiy Feed Entries made outside of site show @@NULL@@ Created: 01-Dec-16  Updated: 06-Jun-17  Resolved: 16-Dec-16

Status: Closed
Project: Alfresco One Platform
Component/s: Activities, Share Application
Affects Version/s: 5.2 EA, 5.0.4, 5.1.1, 4.2.6
Fix Version/s: 5.2

Type: Bug Priority: Critical
Reporter: Jared Ottley Assignee: Closed Issues
Resolution: Fixed Votes: 0
Labels: kanban, triaged
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File PassIn42n.png     PNG File Screen Shot 2016-12-01 at 9.54.12 AM.png    
Issue Links:
Duplicate
duplicates ACE-5416 [Win10, Chrome 51] Null value for com... Closed
Problem/Incident
is caused by MNT-15679 Delete comment updates the "Modifier"... Closed
Related
relates to ACE-3082 Alfresco 5 "My Activities" in @@NULL@@ Closed
relates to MNT-17230 Share: "@@NULL@@" in my activities de... Closed
Build Location: https://bamboo.alfresco.com/bamboo/browse/ALF-EPACK20-368/artifact/JOB1/ALL/
Affects:
User Interface

 Description   

The changes introduced in MNT-15679 are causing invalid entries to be posted to the activity feed. When a comment is made outside of a site (My Files, Shared Files, Repository, 3rd Party add-ons (Aikau Components, Salesforce Connector, etc) an entry is made to the activity feed that reports that something has occurred to a document in @@NULL@.

When the refactoring of the comments web scripts was made it removed a null/empty string check that would have protected entries from being made to the activity feed that is made outside of sites.

I do like that we can now see activity on content outside of the site structures but the code will need to be made more robust to know if it was made in a site or one of the several other locations where the comment functionality is supported.

Steps to reproduce:
1. Add a document to Shared Files.
2. Add a comment to the document added in Shared Files.
3. View the Activity feed to see an entry about the comment activity.

Expected Results:
In 4.2.6, 5.0.4, 5.1.1, 5.2 EA: An entry stating that your user made a comment on the document name.

Actual Results
In 4.2.6, 5.0.4, 5.1.1, 5.2 EA: An entry stating that your user made a comment on the document name in @@NULL@@



 Comments   
Comment by Kevin Roast [X] (Inactive) [ 07-Dec-16 ]

MyFiles should not be generating Activities - they are Site only see ACE-3082

Comment by Kevin Roast [X] (Inactive) [ 07-Dec-16 ]

>Hence, quick fix is not post the activity if it is outside of the site.
Feature improvements aside, I think this is the correct solution for this bug for now.

Comment by Kevin Roast [X] (Inactive) [ 08-Dec-16 ]

This will also then fix linked issue: MNT-17230

Comment by Ramona Neamtu [ 09-Dec-16 ]

If siteInfo does not exists do not post comment related activity.

Please review CR-641

Comment by Kevin Roast [X] (Inactive) [ 12-Dec-16 ]

Please merge

Comment by Ramona Neamtu [ 13-Dec-16 ]

Changes committed in BRANCHES/DEV/5.2.N @ revision r133567.
Merged into
– BRANCHES/DEV/5.1.N @ revision r133582
– BRANCHES/DEV/5.0.N @ revision r133583
– BRANCHES/DEV/V4.2-BUG-FIX @ revision r133584

Comment by Ramona Neamtu [ 16-Dec-16 ]

After some debug on the case 2b from above comment, the siteInfo in this specific case is null.
Since you are not navigating to a site dashboard/document library, the navigation through Repository is not the same, so the activity will not be posted.

Kevin Roast [X], John Knowles, is the 2b case an issue? Should comment activities be posted in this case too?
If yes, I will have to make a call to siteService in order to get the siteInfo, since is not sent on the request.

Please advise!

Comment by Kevin Roast [X] (Inactive) [ 16-Dec-16 ]

>2b. In the Site context: Through Repository: i.e. comment on a file navigating to Repository > Sites > sitename > documentLibrary > file

This is expected - you need to be in what Share consider is the "site" context on the URL eg. share/site/xyz

Comment by Indy Sandhu [ 06-Jun-17 ]

Issue shipped with 5.2, so changed Fix Version from 5.2.N to 5.2.

Generated at Mon Jul 13 19:58:07 BST 2020 using JIRA 7.6.3#76005-sha1:8a4e38d34af948780dbf52044e7aafb13a7cae58.