[ALF-22073] MailActionExecutor doesn't consider email bodies with a HTML doctype as HTML Created: 05-Mar-19  Updated: 16-Oct-19  Resolved: 26-Mar-19

Status: Closed
Project: Alfresco
Component/s: Repository
Affects Version/s: Community Edition 201810 EA
Fix Version/s: ACS 201910-EA
Security Level: external (External user)

Type: Bug Priority: Major
Reporter: Nick Burch (Inactive) Assignee: Closed Issues
Resolution: Fixed Votes: 0
Labels: triaged
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File AlfrescoPatch.diff    
Issue Links:
Shadow
shadowed by REPO-4268 [ServicePack] ALF-22073: MailActionEx... Done
Date of First Response:
Triage: MNT

 Description   

In order to get the correct rendering in Outlook, we need to update some of our HTML email templates to include a doctype at the start. However, this causes Alfresco to send them as Plain Text instead of HTML, because the logic in MailActionExecutor to decide if a FTL template rendered into HTML or Plain Text only considers the opening HTML tag, not a HTML Doctype declaration

The logic in the isHTML method needs to consider this too.

(Git blame won't go far enough back to check, but I have a nasty feeling I may be the original author of this method...)

Patch with unit test attached



 Comments   
Comment by Alexandru Epure [ 26-Mar-19 ]

See comment : https://issues.alfresco.com/jira/browse/REPO-4268?focusedCommentId=610184&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-610184

Generated at Fri Sep 25 20:46:27 BST 2020 using Jira 7.13.15#713015-sha1:7c5ddd2c3e1709974ae9c48c17df8edd3919fe2c.