[ALF-22097] T Engine - add source nodeId parameter Created: 10-Aug-19  Updated: 16-Oct-19  Resolved: 13-Aug-19

Status: Closed
Project: Alfresco
Component/s: Repository
Affects Version/s: Community Edition Next, Community Edition 201901 GA
Fix Version/s: ACS 201910-EA
Security Level: external (External user)

Type: Improvement Priority: Unprioritized
Reporter: Daniel Gradecak (Inactive) Assignee: Closed Issues
Resolution: Fixed Votes: 0
Labels: OSS-REQUEST, triaged
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Shadow
shadowed by REPO-4615 T Engine - add sourceNodeRef parameter Done
Date of First Response:
Triage: To Do

 Description   

It would help to have the source nodeId in the "always supplied" parameters for a T Engine transform call. While basing transformations only on content is logical but some transformations might need extra metadata of the source, imagine building a templating engine where some metadata would end up in the specific "template document" transformation.

 

I cna think of two possibilities, either provide the nodeId to T-Engines, so the custom engine could use it and call back the REPO for extra information, either allow some kind of dynamic transformation options that a RenditionDefinition2 might invoke before checking the transformation option but that is not a good option. I would go with the first approach.

 

So what is needed, to have a way to get source node informations (not just mimetype) on the T Engine side.

 

org.alfresco.repo.content.transform.LocalTransformImpl.transformImp 

 

add

args[i++] = "sourceNodeId";
args[i++] = sourceNodeRef.getId();



 Comments   
Comment by Alan Davis [ 12-Aug-19 ]

Thank you for your suggestion. As part of REPO-4615 we plan to auto populate a sourceNodeRef value if it has been supplied as part of the rendition definition without a value.  

Comment by Daniel Gradecak (Inactive) [ 12-Aug-19 ]

If I may suggest to have the source ID instead of the source nodeRef, just to stay in the "REST API" fashion. In my opinion it makes sense so it is node needed to do extra processing on the T engine side in order to use the rest API callback for instance.

Not sure if it would make sense for you, but in the same way where through the rendition definition you would define the "sourceId" for instance, it could be a greater value even to have the possibility to include property metadata names that we want transfered. But there you might have more issues with converrters for instance. Just give it a thought and if it makes no sense than the sourceId is completely fine.

 

Generated at Fri Sep 25 18:27:51 BST 2020 using Jira 7.13.15#713015-sha1:7c5ddd2c3e1709974ae9c48c17df8edd3919fe2c.