[Bulk Actions] Search Results Bulk Actions (SHA-1439)

[SHA-1796] Error message is inappropriate when Copy/Move fails as the user has no permission to do so in the destination folder. Created: 04-Oct-16  Updated: 17-Jul-20  Resolved: 24-Oct-16

Status: Done
Project: Share Application
Component/s: Share Application
Affects Version/s: None
Fix Version/s: None

Type: Sub-task
Reporter: Charulatha Ganesh [X] (Inactive) Assignee: Unassigned
Resolution: Done Votes: 0
Labels: kanban
Remaining Estimate: 0 minutes
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

r131068-b105


Attachments: PNG File error pop up.png     PNG File move failure when user has no permission.png     PNG File notification failure.png    
Issue Links:
Cloners
Related

 Description   

Steps to Reproduce:

1. Create two users (ex) user1, user2
2. Login as user1
3. Create any site (ex) site1 with files and folders (ex) myfile,myfilefolder
4. invite user2 to site1 with collaborator role
5. Logout from user1
6. Login as user2
7. Search 'myfile' in the search field
8. Select the checkbox on 'myfile', myfilefolder' in search results page.
9. Select 'Move/copy from selected items drop menu
10. Select the destination folder Repository>User Homes and confirm Copy/Move.
11. View the error message

Expected:
Appropriate error message should be displayed like 'Files and Folders cannot be moved/copied as the user has no permission to do so in the destination folder.

Actual:
The files or folders couldn't be moved/copied right now. Check they're not locked for editing and try again.

Ref: Screenshot attached



 Comments   
Comment by Charulatha Ganesh [X] (Inactive) [ 04-Oct-16 ]

Andy Healey [X] - Can you please add your comments.

Comment by Charulatha Ganesh [X] (Inactive) [ 04-Oct-16 ]

Kevin Roast [X] /David Draper [X] -User with permission can move/ copy files even when the files are locked for editing offline. Can any one confirm is it the expected behavior?

Comment by Andy Healey [X] (Inactive) [ 04-Oct-16 ]

The error message was added recently, but sounds like it's not correct here.

Either need a new error message for this situation, or can extend the current one to say:

"The files or folders couldn't be moved/copied right now. Check they're not locked for editing and that you have permission to add files to the destination folder."

Comment by Charulatha Ganesh [X] (Inactive) [ 04-Oct-16 ]

Andy Healey [X] - I think 'Check they're not locked for editing' should not be displayed as well, as user can move/copy even when the files are locked for editing.

Comment by Andy Healey [X] (Inactive) [ 05-Oct-16 ]

In that case it sounds like a message from a different situation is being used.

1. Can you check the situation when that message would be used correctly - I'm assuming there must be a case where a locked file stops it being moved or copied or the error message is redundant.

2. For this situation the correct message would be: "The files or folders couldn't be moved/copied right now. Check that you have permission to add files to the destination folder."

Thanks

Comment by David Draper [X] (Inactive) [ 05-Oct-16 ]

The problem is that we just don't know what has caused the failure... we just know that a failure has occurred. When moving copying/moving multiple files there could be different reasons that have simultaneously caused the action to fail (i.e. different reasons for different files).

Comment by Andy Healey [X] (Inactive) [ 05-Oct-16 ]

David Draper [X], so is the current error message accurate in some cases, ie that the file is locked and is causing them problem?

Looking at SHA-1730 with either go with an error message that suggests 2 or 3 resolutions and says or check with IT admin, or a super generic "mistakes happen" message.

I'd prefer the former, in which case can we get the top most likely cause or error and I can bundle them into 1 message?

Comment by David Draper [X] (Inactive) [ 05-Oct-16 ]

Andy Healey [X] Yes - in some circumstances it could be true. The problem is that there are all sorts of scenarios that could cause the failure and this information is not reported when we call the API... and it could be more than one reason. I think what we need is some generic error message, which isn't ideal ... otherwise we're just going to be listing endless possibilities!

Comment by David Draper [X] (Inactive) [ 06-Oct-16 ]

Andy Healey [X] I think we need to go super generic... could you suggest a wording please? "It was not possible to move the items", etc?

Comment by Andy Healey [X] (Inactive) [ 06-Oct-16 ]

"The files or folders couldn't be moved/copied right now. Try again, or check with your IT Team."

Comment by Charulatha Ganesh [X] (Inactive) [ 13-Oct-16 ]

David Draper [X] - Can you please let me know the revision details to verify this issue?

Comment by David Draper [X] (Inactive) [ 13-Oct-16 ]

Charulatha Ganesh [X] It needs to be using revision r131288 (and Aikau 1.0.90)

Comment by Charulatha Ganesh [X] (Inactive) [ 13-Oct-16 ]

Retested this issue r131380-b123 and still I could see notification failure and error pop up as well. Please find the attached screen shots. I think we are expecting one general error message for all possible failures.
David Draper [X] - Can you please review the screen shots and add your comments.

Comment by David Draper [X] (Inactive) [ 13-Oct-16 ]

Charulatha Ganesh [X] I think the screenshot you're showing is the new general error message.

Comment by Andy Healey [X] (Inactive) [ 17-Oct-16 ]

Generic error message should be:

"The files or folders couldn't be moved/copied right now. Try again, or check with your IT Team."

Comment by Charulatha Ganesh [X] (Inactive) [ 24-Oct-16 ]

Retested this issue on r131683-b136 and seems to be working fine now.
So,closing this issue.

Comment by Iulian Mitrea [X] (Inactive) [ 28-Nov-16 ]

Steps to reproduce:
1. Upload a file on multiple sites
2. Search the name of the file
3. In the Search page select the returned files and then chose "Move to" option

Actual result:
"The file or folder couldn't be moved right now. Try again, or check with your IT Team."

Expected result:
First file should be moved and for the rest of the files "The move could not be completed. A file with the same name already exists"

Generated at Fri Dec 04 05:47:34 GMT 2020 using Jira 7.13.15#713015-sha1:7c5ddd2c3e1709974ae9c48c17df8edd3919fe2c.